Skip to content

feat(localization): adding localization support for the entityTabs title coming from dynamic-plugins.default.yaml and defaultTabs.tsx #3503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

feat(localization): adding localization support for the entityTabs title coming from dynamic-plugins.default.yaml and defaultTabs.tsx #3503

wants to merge 9 commits into from
+217 −13

Conversation

its-mitesh-kumar
Copy link
Member

Description

Adding Localization support for EntityTabs being added from

  1. dynamic-plugins.default.yaml :
            entityTabs:
              - path: /workflows
                title: Workflows
                titleKey: app.entityPage.workflows.title
                mountPoint: entity.page.workflows
  1. defaultTabs.tsx

Which issue(s) does this PR fix

UI after changes

Screen.Recording.2025-10-03.at.6.48.04.PM.mov

How to test changes / Special notes to the reviewer

  • You can mocked up all the defaults tabs and Workflow tabs using below configuration
frontend:
          
    backstage-community.plugin-jfrog-artifactory:
      entityTabs:
        # 1. Overview tab
        - path: /
          title: Overview
          titleKey: app.entityPage.overview.title
          mountPoint: entity.page.image-registry
        # 2. Topology tab  
        - path: /topology
          title: Topology
          titleKey: app.entityPage.topology.title
          mountPoint: entity.page.image-registry
        # 3. Issues tab
        - path: /issues
          title: Issues
          titleKey: app.entityPage.issues.title
          mountPoint: entity.page.image-registry
        # 4. Pull/Merge Requests tab
        - path: /pr
          title: Pull/Merge Requests
          titleKey: app.entityPage.pullRequests.title
          mountPoint: entity.page.image-registry
        # 5. CI tab
        - path: /ci
          title: CI
          titleKey: app.entityPage.ci.title
          mountPoint: entity.page.image-registry
        # 6. CD tab
        - path: /cd
          title: CD
          titleKey: app.entityPage.cd.title
          mountPoint: entity.page.image-registry
        # 7. Kubernetes tab
        - path: /kubernetes
          title: Kubernetes
          titleKey: app.entityPage.kubernetes.title
          mountPoint: entity.page.image-registry
        # 8. Image Registry tab
        - path: /image-registry
          title: Image Registry
          titleKey: app.entityPage.imageRegistry.title
          mountPoint: entity.page.image-registry
        # 9. Monitoring tab
        - path: /monitoring
          title: Monitoring
          titleKey: app.entityPage.monitoring.title
          mountPoint: entity.page.image-registry
        # 10. Lighthouse tab
        - path: /lighthouse
          title: Lighthouse
          titleKey: app.entityPage.lighthouse.title
          mountPoint: entity.page.image-registry
        # 11. API tab
        - path: /api
          title: Api
          titleKey: app.entityPage.api.title
          mountPoint: entity.page.image-registry
        # 12. Dependencies tab
        - path: /dependencies
          title: Dependencies
          titleKey: app.entityPage.dependencies.title
          mountPoint: entity.page.image-registry
        # 13. Docs tab
        - path: /docs
          title: Docs
          titleKey: app.entityPage.docs.title
          mountPoint: entity.page.image-registry
        # 14. Definition tab
        - path: /definition
          title: Definition
          titleKey: app.entityPage.definition.title
          mountPoint: entity.page.image-registry
        # 15. Diagram tab (System)
        - path: /system
          title: Diagram
          titleKey: app.entityPage.diagram.title
          mountPoint: entity.page.image-registry
      mountPoints:
        - mountPoint: entity.page.image-registry/cards
          importName: JfrogArtifactoryPage
          config:
            layout:
              gridColumn: 1 / -1

@openshift-ci openshift-ci bot requested review from davidfestal and josephca October 3, 2025 13:26
@its-mitesh-kumar its-mitesh-kumar changed the title Feat/enitity tabs localization feat(localization): adding localization support for the entityTabs title coming from dynamic-plugins.default.yaml and defaultTabs.tsx Oct 3, 2025
christoph-jerolimov
christoph-jerolimov requested changes Oct 3, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 3, 2025

The image is available at:

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 3, 2025

The image is available at:

@christoph-jerolimov
Copy link
Member

/retest

christoph-jerolimov
christoph-jerolimov reviewed Oct 3, 2025
View reviewed changes
Copy link
Member

@christoph-jerolimov christoph-jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff looks good but I didn't tested it yet

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 3, 2025

The image is available at:

@its-mitesh-kumar
Copy link
Member Author

/test e2e-ocp-helm

@christoph-jerolimov
Copy link
Member

/retest

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 6, 2025

The image is available at:

@its-mitesh-kumar
Copy link
Member Author

/retest

2 similar comments
@its-mitesh-kumar
Copy link
Member Author

/retest

@HusneShabbir
Copy link
Contributor

/retest

@jrichter1
Copy link
Contributor

Looking at the test failures, the following error keeps appearing for multiple plugins when accessed from a component's tab:
image

Happens with topology, kubernetes, quay, and techdocs. This doesn't seem like the tests are at fault.

Also, some github rate limit errors here and there for good measure.

@jrichter1
Copy link
Contributor

Full error, without the cropping

Error: Routable extension component with mount point routeRef{type=absolute,id=techdocs:catalog-reader-view} was not discovered in the app element tree. Routable extension components may not be rendered by other components and must be directly available as an element within the App provider component.
    at a (https://rhdh-developer-hub-showcase.apps.rhdh-4-18-us-east-2-j98wk.rhdh-qe.devcluster.openshift.com/static/1963.010c7147.chunk.js:1:6363)
    at Ri (https://rhdh-developer-hub-showcase.apps.rhdh-4-18-us-east-2-j98wk.rhdh-qe.devcluster.openshift.com/static/3144.9985b1b4.chunk.js:14:16975)
    at Qi (https://rhdh-developer-hub-showcase.apps.rhdh-4-18-us-east-2-j98wk.rhdh-qe.devcluster.openshift.com/static/3144.9985b1b4.chunk.js:16:3148)
    at ua (https://rhdh-developer-hub-showcase.apps.rhdh-4-18-us-east-2-j98wk.rhdh-qe.devcluster.openshift.com/static/3144.9985b1b4.chunk.js:16:44292)
    at ta (https://rhdh-developer-hub-showcase.apps.rhdh-4-18-us-east-2-j98wk.rhdh-qe.devcluster.openshift.com/static/3144.9985b1b4.chunk.js:16:39558)
    at Zc (https://rhdh-developer-hub-showcase.apps.rhdh-4-18-us-east-2-j98wk.rhdh-qe.devcluster.openshift.com/static/3144.9985b1b4.chunk.js:16:39489)
    at ml (https://rhdh-developer-hub-showcase.apps.rhdh-4-18-us-east-2-j98wk.rhdh-qe.devcluster.openshift.com/static/3144.9985b1b4.chunk.js:16:39348)
    at iu (https://rhdh-developer-hub-showcase.apps.rhdh-4-18-us-east-2-j98wk.rhdh-qe.devcluster.openshift.com/static/3144.9985b1b4.chunk.js:16:35766)
    at qs (https://rhdh-developer-hub-showcase.apps.rhdh-4-18-us-east-2-j98wk.rhdh-qe.devcluster.openshift.com/static/3144.9985b1b4.chunk.js:16:34722)
    at Ln (https://rhdh-developer-hub-showcase.apps.rhdh-4-18-us-east-2-j98wk.rhdh-qe.devcluster.openshift.com/static/3144.9985b1b4.chunk.js:24:1614)

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 6, 2025

The image is available at:

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 6, 2025

The image is available at:

debsmita1
debsmita1 approved these changes Oct 6, 2025
View reviewed changes
Copy link
Member

@debsmita1 debsmita1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the changes locally

Image

Verified it on a cluster

Screenshot 2025-10-07 at 12 07 19 AM

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 18, 2025
@invincibleJai
Copy link
Member

/retest

1 similar comment
@invincibleJai
Copy link
Member

/retest

@invincibleJai invincibleJai force-pushed the feat/enitity-tabs-localization branch from f305716 to 72d79a5 Compare October 18, 2025 17:58
@openshift-ci openshift-ci bot removed the lgtm label Oct 18, 2025
@invincibleJai
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 18, 2025
@invincibleJai
Copy link
Member

/cherrypick release-1.8

@openshift-cherrypick-robot
Copy link
Contributor

@invincibleJai: once the present PR merges, I will cherry-pick it on top of release-1.8 in a new PR and assign it to you.

In response to this:

/cherrypick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@github-actions GitHub Actions
Copy link
Contributor

The image is available at:

@invincibleJai
Copy link
Member

/retest

1 similar comment
@invincibleJai
Copy link
Member

/retest

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 19, 2025

@its-mitesh-kumar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ocp-helm 72d79a5 link true /test e2e-ocp-helm

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@invincibleJai
Copy link
Member

/retest

@its-mitesh-kumar @invincibleJai
feat(localization): add localization support for entityTabs
a0f1a28 
Signed-off-by: its-mitesh-kumar <[email protected]>
@its-mitesh-kumar @invincibleJai
translating default tab
210109d 
Signed-off-by: its-mitesh-kumar <[email protected]>
@its-mitesh-kumar @invincibleJai
removing translation ref from default
9eeadb5 
Signed-off-by: its-mitesh-kumar <[email protected]>
@its-mitesh-kumar @invincibleJai
moving prefix of key from app to catalog
b9d1d55 
Signed-off-by: its-mitesh-kumar <[email protected]>
@its-mitesh-kumar @invincibleJai
fixing buld fail
922b407 
Signed-off-by: its-mitesh-kumar <[email protected]>
@its-mitesh-kumar @invincibleJai
trying by passing titleKey in scorecard
ac3cb7b 
Signed-off-by: its-mitesh-kumar <[email protected]>
@its-mitesh-kumar @invincibleJai
passing trnaslated tab component
cd84074 
Signed-off-by: its-mitesh-kumar <[email protected]>
@its-mitesh-kumar @invincibleJai
adding back comment
3605a44 
Signed-off-by: its-mitesh-kumar <[email protected]>
@its-mitesh-kumar @invincibleJai
keeping previous type
d21c189 
Signed-off-by: its-mitesh-kumar <[email protected]>
@invincibleJai invincibleJai force-pushed the feat/enitity-tabs-localization branch from 72d79a5 to d21c189 Compare October 19, 2025 06:02
@openshift-ci openshift-ci bot removed the lgtm label Oct 19, 2025
@invincibleJai
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 19, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christoph-jerolimov, debsmita1, invincibleJai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [christoph-jerolimov,debsmita1,invincibleJai]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christoph-jerolimov christoph-jerolimov christoph-jerolimov approved these changes

@debsmita1 debsmita1 debsmita1 approved these changes

@davidfestal davidfestal Awaiting requested review from davidfestal

@josephca josephca Awaiting requested review from josephca

Assignees

@invincibleJai invincibleJai

@debsmita1 debsmita1

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@its-mitesh-kumar @christoph-jerolimov @HusneShabbir @jrichter1 @debsmita1 @invincibleJai @openshift-cherrypick-robot